Bug 731013 - cross-compilation broken when building extract-strings
authorJehan <jehan@girinstud.io>
Wed, 13 Aug 2014 05:08:08 +0000 (05:08 +0000)
committerJehan <jehan@girinstud.io>
Wed, 13 Aug 2014 21:03:51 +0000 (21:03 +0000)
It is actually a bad idea to use noinst_PROGRAMS for build tools,
because it adds a $(EXEEXT). It is best to override the all target
with all-local to trigger the tool build.

gtk/Makefile.am
gtk/inspector/Makefile.am
util/Makefile.am

index 5c31084a7ac565a8783916eeedd576427e63dcad..7b78fb87d4e8d4cfeab59192961a7fa5ee069a37 100644 (file)
@@ -1566,7 +1566,7 @@ distclean-local:
        if test $(srcdir) != .; then \
          rm -f $(MAINTAINERCLEANFILES); \
          rm -rf stock-icons; \
-         rm -f extract-strings$(EXEEXT); \
+         rm -f extract-strings$(BUILD_EXEEXT); \
          rm -f $(template_headers); \
        fi
 
index 9e1494514246fde565da7bd76ad7c81ce45b9f06..7b1876fedb3f643ef7555eeef0b0307c61ae314d 100644 (file)
@@ -114,7 +114,7 @@ templates =                                 \
 
 template_headers = $(templates:.ui=.ui.h)
 
-extract_strings = $(top_builddir)/util/extract-strings
+extract_strings = $(top_builddir)/util/extract-strings$(BUILD_EXEEXT)
 
 %.ui.h : %.ui 
        $(AM_V_GEN) $(extract_strings) $< > $@
index e8cf8fdca03ec366f243ab6987c676d3590c6be5..d0aa488f465c2580338cf14ea435558b91604623 100644 (file)
@@ -4,10 +4,10 @@ extract_strings_cppflags =
 extract_strings_cflags = $(GLIB_CFLAGS_FOR_BUILD)
 extract_strings_ldadd = $(GLIB_LIBS_FOR_BUILD)
 
-extract-strings$(EXEEXT): $(extract_strings_sources)
-       @rm -f extract-strings
+extract-strings$(BUILD_EXEEXT): $(extract_strings_sources)
+       @rm -f extract-strings$(BUILD_EXEEXT)
        $(AM_V_CCLD)$(CC_FOR_BUILD) $(extract_strings_cppflags) $(CPPFLAGS_FOR_BUILD) $(extract_strings_cflags) $(CFLAGS_FOR_BUILD) $^ $(LDFLAGS_FOR_BUILD) $(extract_strings_ldadd) $(LIBS_FOR_BUILD) -o $@
 
-noinst_PROGRAMS = extract-strings
+all-local: extract-strings$(BUILD_EXEEXT)
 
 -include $(top_srcdir)/git.mk